Refactor sprites build - #1691
Open
FallenDeity wants to merge 2 commits into
Open
FallenDeity wants to merge 2 commits into
FallenDeity wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Cloning all of the sprites submodule just to build this repo is redundant since all we do is just check paths the actual sprite data is never used, hence this pr now uses the manifest published whenever there is a change in sprites repo to build the sprites introduced in pr PokeAPI/sprites#289
a manifest is published both as raw json and gzipped json in compressed format for example view here https://pokeapi.github.io/sprites/manifest.json its published both via releases and github pages which is used as a catalogue to build all the data for sprites in
build.pyAI coding assistance disclosure
None
Contributor check list