Skip to content

feat: Centralize sprite lookup config, update logic for sprite lookup - #1681

Merged
Naramsim merged 1 commit into
PokeAPI:masterfrom
FallenDeity:update-sprite-logic
Sep 24, 2026
Merged

Naramsim merged 1 commit into
PokeAPI:masterfrom
FallenDeity:update-sprite-logic

Conversation

@FallenDeity

Copy link
Copy Markdown
Contributor

Change description

Updates the sprite build logic with a centralized look up config, on default pokemon sprites not much changes than extra config and lookup additions.

slight logic change on forms side now forms side gives <pokemon-id>-<form-suffix> sprites from all lookup directories than limited ones before

for pokemon which are default i.e no form suffix it falls back and serves the normal pokemon-id sprites instead i wanted to have this structure sparse i.e null for all non form entries but that might break some ppls apps since we currently serve default sprites from forms too https://pokeapi.co/api/v2/pokemon-form/6 so for now there is duplication

maybe we can do this with an announcement later with a deprecation period

AI coding assistance disclosure

None

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Naramsim
Naramsim merged commit 6bbd96b into PokeAPI:master Sep 24, 2026
22 checks passed
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Sep 24, 2026
@pokeapi-machine-user

Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants