Repository navigation
Conversation
Member
|
This is not necessary as all settings updates and conversions should be done through the PlayCover app. PlayCover handles these updates on load, so PlayTools would not view older versions of a settings file. It is highly unlikely for PlayTools to view an outdated settings profile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older settings plists can omit newer keys such as
displayRotation. Synthesized decoding then throws, causingPlaySettingsto fall back to all defaults and ignore saved values such as resizable window mode and keymapping.Decode each missing top-level field using its existing default while preserving saved values and still rejecting invalid types. Extract the model into a Foundation-only file and add standalone regression tests against the production decoder.
Validation:
bash Tests/run-settings-tests.sh: all four checks pass (legacy XML/binary plists, empty settings, current settings round-trip, invalid types). The legacy and empty cases fail with the original decoder.--strict: passes for all changed Swift files.git diff --check: pass.Full iOS framework build not run: this machine has Command Line Tools but no full Xcode installation.