Repository navigation
test(e2e): cover every section and assert real outcomes - #325
Merged
Merged
Conversation
Most e2e tests could not fail: they checked that some element was visible, hid failed assertions behind .catch(), or skipped themselves when mock data was missing. Drivers, modules, repositories, triggers, groups and navigation had no tests. - Add specs for drivers, modules, repositories, triggers, groups and navigation. - Rewrite the systems, zones, users, domains, admin, mobile and cascade delete specs to check names, URLs, table rows and changes that stay after a reload. - Share helpers in BasePage, FeaturePage and MobilePage. Add a fixture that switches on mock mode and seeds mock data. - Fill mock gaps the flows need: a groups backend, a default domain, stable user ids with first and last names, user filters by domain, zone tags as arrays, and the schema, platform and cluster versions endpoints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Most e2e tests could not fail. They checked that some element was visible, hid failed assertions behind
.catch(() => undefined), or usedif (count > 0)guards that skipped them when the mock had no data (domains and triggers have none). Drivers, modules, repositories, triggers, groups and navigation had no e2e tests.Changes
page.reload(). NowaitForTimeoutis left.BasePagehelpers for the list/detail layout (gotoItem,openTab,createWith,deleteSelected,discardChanges,tableRow,notification), plusFeaturePageandMobilePagein place of five page objects. A fixture switches on mock mode, andseedMockData/seedSessionseed mock data.schema,platformandcluster/versionsendpoints, whose load errors covered the admin menu after fix(ui): resolve UX audit issues across workflows #324e2e/README.mdnow describes how to write tests. Addsuser-stories/groups.md.Tests
chromium+mobile-chrome: 314/314 with--repeat-each=2webkit+mobile-safari: 157/157firefox.launch()times out with no tests), so CI runs it for the first time.App bugs found (not fixed here)
module-state.service.tssetsitem.runningin place, so the signal does not fire.name(no last name, e.g. from SSO) cannot be edited, because Last Name is required.form.driveris never invalid, because the schema requiresdriver_id./<folder>/CHANGELOG.mdwith plainfetch, which goes through the dev proxy to placeos-dev. The spec stubs it.Reviewed with sol-loop: 4 rounds with gpt-6.1-sol on high. The last round covered the spec and mock updates for the #324 UI after the rebase (new button names, the "Discard changes?" prompt, inline validation, the missing mock endpoints).
Changes made by Claude Opus 5.5 (
claude-opus-5-5) in Claude Code, running in T3 Code.🤖 Generated with Claude Code