Skip to content

Update SC2 ladder types and skip invalid player smoke case - #4

Merged
Pinta365 merged 3 commits into
mainfrom
copilot/fix-api-drift-issues
Oct 12, 2026
Merged

Pinta365 merged 3 commits into
mainfrom
copilot/fix-api-drift-issues

Conversation

Copilot AI commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

The drift check found two undeclared fields in SC2 ladder responses and a smoke-test 404 caused by the placeholder account ID 12345.

  • Ladder response types: Declare localizedDivision and ranksAndPools[].bonusPool.
  • Player smoke test: Skip the case when no valid SC2 account ID is available.
localizedDivision: string;
ranksAndPools: {
    rank: number;
    mmr: number;
    bonusPool: number;
}[];

Copilot AI linked an issue Oct 12, 2026 that may be closed by this pull request
Co-authored-by: Pinta365 <19735646+Pinta365@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix API drift issues reported in weekly check Update SC2 ladder types and skip invalid player smoke case Oct 12, 2026
Copilot AI requested a review from Pinta365 October 12, 2026 15:41
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Pinta365
Pinta365 marked this pull request as ready for review October 12, 2026 17:36
@Pinta365
Pinta365 merged commit b9329fb into main Oct 12, 2026
1 check passed
@Pinta365
Pinta365 deleted the copilot/fix-api-drift-issues branch October 12, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API drift detected

2 participants