Skip to content

Ignore inconsistent end-line mismatch - #180

Open
christophfroehlich wants to merge 6 commits into
mainfrom
fix-lcov
Open

christophfroehlich wants to merge 6 commits into
mainfrom
fix-lcov

Conversation

@christophfroehlich

Copy link
Copy Markdown
Collaborator

From https://github.com/PickNikRobotics/RSL/actions/runs/39043705764/job/117428124753?pr=178

 lcov: ERROR: (inconsistent) mismatched end line for _ZN12_GLOBAL__N_134ns_CATCH2_INTERNAL_TEMPLATE_TEST_1L8reg_testIfEEvNS0_8TypeListIJT_EEEN5Catch11NameAndTagsE at /__w/RSL/RSL/tests/static_vector.cpp:5: 94 -> 5 while capturing from ./build/codecov/tests/CMakeFiles/test-rsl.dir/static_vector.cpp.gcda
	(use "lcov --ignore-errors inconsistent ..." to bypass this error)

@christophfroehlich
christophfroehlich changed the base branch from main to clang-tidy-21 October 17, 2026 15:38
Base automatically changed from clang-tidy-21 to main October 17, 2026 15:59
@tylerjw

tylerjw commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

This does fix the error by ignoring it. Is there a way we could fix the error without ignoring it?

@christophfroehlich

Copy link
Copy Markdown
Collaborator Author

You are right. I poked a different LLM and it suggested to exclude the test folder form coverage results, because

The offending symbol is a Catch2-generated template-test registration function in tests/static_vector.cpp, not RSL library code.
This avoids the problematic test metadata without disabling validation for production code. It is a targeted workaround, not a compiler fix; if you need coverage of the test sources themselves, you would need a verified working GCC/gcov combination or an upstream fix. The underlying class of inconsistent metadata is discussed in linux-test-project/lcov#310. I verified the current workflow and failure logs, but have not run the proposed change.

not sure if a real fix exists.

@christophfroehlich

Copy link
Copy Markdown
Collaborator Author

I see that the upload to codecov fails

[369](https://github.com/PickNikRobotics/RSL/actions/runs/39384765794/job/118501865619?pr=180#step:15:1387)
  info - 2026-10-20 07:13:43,478 -- Upload queued for processing complete
  error - 2026-10-20 07:13:43,478 -- Upload queued for processing failed: {"message":"Token required because branch is protected"}

and nothing is reported there.
https://app.codecov.io/gh/PickNikRobotics/RSL/pulls

I am not part of the PickNikRobotics org on codecov, I can't debug that further

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants