Repository navigation
Use stock EGit compare with pull request comments - #61
Merged
Merged
Conversation
Co-authored-by: Kurrle, Philipp <philipp.kurrle+ADVNTST@advantest.com>
Co-authored-by: Kurrle, Philipp <philipp.kurrle+ADVNTST@advantest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegates Synchronize file opening to EGit's stock compare action instead of a custom compare input, and binds the existing pull request comment painting to that editor's TextMergeViewer. Commentable lines now come from the local Git commit range backing the Synchronize session rather than provider patch data.
PullRequestOpenInCompareAction resolves the repository-relative path (including EGit GitModelBlob selections), runs the default open action, then schedules the overlay. CompareCommentOverlayBinder locates the opened compare viewer, installs CommentOverlayInstaller, and disposes it alongside the viewer control so rulers are not duplicated. LocalDiffLineCalculator computes commentable lines with JGit's DiffFormatter, PullRequestContext tracks the repository plus base and head revisions, and DiffHunkParser ignores full-patch headers so local Git output parses correctly.
Removes PullRequestCompareEditorInput, RemoteFileTypedElement, RemoteFileEditorInput, EmptyTypedElement, and PullRequestChangedFile, along with the now-unused getFileContent client API. README.md and AGENTS.md describe the Synchronize-based flow.
Testing: ./mvnw clean verify passes with 126 tests and a successful Tycho build. New tests cover comment filtering by nested repository path and commentable lines derived from a real local commit range. Manual Eclipse workbench testing was not possible here, as the environment has no Eclipse executable.