Repository navigation
test(runtime): port two stale debug tests to the step 7 model - #12612
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12611. Two perry-runtime tests failed in debug builds on main, both before and after object model step 7. Test-only change.
array_record_prototype_symbol_identity_guard, ported to the step 7 model. The test used to change the iterator member's identity by rewriting Array.prototype's key list behind the shape. Since step 7, the fixedSymbol.iteratorslot is the authority, so that rewrite no longer means anything. The test now moves the genuinevaluesbody to an unrelated member (Symbol.toStringTag) and stores another function in the iterator slot. Entry must refuse (js_array_record_needs_iterator == 1). The test then restores the slot, deletes the extra member and checks that entry is eligible again.weak_collection_summary_agrees_with_shape_brandswas stale. It calledwith_summary(0xFF), which violateswith_summary's debug precondition that onlySUMMARY_KEY_BITSare set (theleft: 224panic, 0xFF & !0x1F). The fact being tested still holds: the test now passes every legal summary bit and still checks that the weak-collection brand survives.Verification (qb6, debug
cargo test -p perry-runtime --lib,--test-threads=1)iteratorarray_recordshapes_storestatic_layout/named_props