Skip to content

fix default panel widths #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeepBot99 merged 1 commit into from
Nov 2, 2026
Merged

fix default panel widths #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/utils/settingsPersistence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,17 @@ import { DEFAULT_SETTINGS } from "../config/defaults";
import type { Settings } from "../types";

// Versioning for settings schema
const SETTINGS_VERSION = "1.0.0";
const SETTINGS_VERSION = "1.0.1";

/**
* Previous cached settings defaulted these to 0; if those were zero we are switching them to the new defaults.
*/
const PANEL_LAYOUT_KEYS = [
"leftPanelWidth",
"rightPanelWidth",
"leftPanelMinWidth",
"rightPanelMinWidth",
] as const;

interface StoredSettings {
version: string;
Expand Down Expand Up @@ -53,7 +63,7 @@ export function normalizeLegacyFieldMap(input: Settings): Settings {
return next;
}

function migrateSettings(stored: Partial<StoredSettings>): Settings {
export function migrateSettings(stored: Partial<StoredSettings>): Settings {
const defaults = { ...DEFAULT_SETTINGS };

if (!stored.settings) {
Expand All @@ -72,6 +82,12 @@ function migrateSettings(stored: Partial<StoredSettings>): Settings {
}
});

if (stored.version !== SETTINGS_VERSION) {
for (const key of PANEL_LAYOUT_KEYS) {
if (!migrated[key]) migrated[key] = defaults[key];
}
}

return normalizeLegacyFieldMap(migrated);
}

Expand All @@ -83,9 +99,6 @@ export async function loadSettings(): Promise<Settings> {
return { ...DEFAULT_SETTINGS };
}
const stored: StoredSettings = JSON.parse(raw);
if (stored.version !== SETTINGS_VERSION) {
// Optionally handle migration here
}
return migrateSettings(stored);
} catch {
return { ...DEFAULT_SETTINGS };
Expand Down
Loading