Skip to content

Bump react, react-dom and @types/react in /js #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump react, react-dom and @types/react in /js #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
"mantine-form-zod-resolver": "^1.3.0",
"motion": "^12.34.2",
"papaparse": "^5.5.3",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react": "^19.3.1",
"react-dom": "^19.3.1",
"react-icons": "^5.4.0",
"react-router": "^6.30.3",
"react-router-dom": "^6.30.3",
Expand All @@ -57,7 +57,7 @@
"@testing-library/react": "^16.3.2",
"@testing-library/user-event": "^14.6.1",
"@types/papaparse": "^5.5.2",
"@types/react": "^18.3.18",
"@types/react": "^19.3.0",
"@types/react-dom": "^18.3.5",
Comment on lines +60 to 61

@graphite-app graphite-app Bot Oct 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/react is bumped to ^19.3.0, but @types/react-dom stays at ^18.3.5. That package declares a peer dependency on @types/react@^18, and the lockfile now resolves it as @types/react-dom@18.3.5(@types/react@19.3.0), which violates the peer range.

The React 18 DOM typings are then checked against React 19 core types. This can cause type-check or build failures, for example around refs, ReactNode or JSX namespace changes, and createRoot/render signatures. Bump @types/react-dom in the same PR so the typings match:

"@types/react-dom": "^19.3.0"
Suggested change
"@types/react": "^19.3.0",
"@types/react-dom": "^18.3.5",
"@types/react": "^19.3.0",
"@types/react-dom": "^19.3.0",

Spotted by Graphite

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

"@types/react-syntax-highlighter": "^15.5.13",
"@vitejs/plugin-react": "^4.3.4",
Expand Down
Loading
Loading