Repository navigation
[BUG FIX] fix chunk_cached_array uxdataset wrapping - #3036
Merged
Merged
Conversation
erikvansebille
approved these changes
Nov 4, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
I assume you've also confirmed that the new test fails without the change in _chunk_cached_array/core.py?
Contributor
Author
|
Yep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures the UxDatasets are properly backed by chunk_cached_arrays following a call to
.to_chunk_cached_array(). See the comments of #3032 for more detailsChecklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure