Skip to content

MAINT: Fix pixi run docs-clean - #3034

Merged
VeckoTheGecko merged 1 commit into
Parcels-code:mainfrom
VeckoTheGecko:fix-clean
Nov 4, 2026
Merged

VeckoTheGecko merged 1 commit into
Parcels-code:mainfrom
VeckoTheGecko:fix-clean

Conversation

@VeckoTheGecko

@VeckoTheGecko VeckoTheGecko commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Description

Updates the MakeFile (hence also the Pixi task) to remove the build folder entirely.

pixi run docs-clean wasn't properly cleaning the cache folder for the jupyter build outputs.

  • rm -rf {BUILD_DIR}/* only matched non-dotfiles (due to how * expressions work)
  • the subsequent line rm -rf .jupyter_cache didn't clean the folder since its located in the BUILD_DIR folder

This meant that .jupyter_cache didn't get cleaned.

Does this match your experience @erikvansebille ?

Checklist

  • Closes None
  • Tests added
  • This PR targets the correct branch (main for normal development, v3-support for v3 support)

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

@VeckoTheGecko
VeckoTheGecko merged commit c83e09a into Parcels-code:main Nov 4, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Nov 4, 2026
@VeckoTheGecko
VeckoTheGecko deleted the fix-clean branch November 4, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants