Skip to content

Update GitHub action to use Checkout version 7 (checkout@v7) & msbuil… #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brett208 merged 1 commit into from
Sep 13, 2026
Merged

Update GitHub action to use Checkout version 7 (checkout@v7) & msbuil… #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/op2helper-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ name: OP2Helper CI

on:
push:
branches: [ main, master, '**' ]
pull_request:
branches: [ main, master ]
Comment on lines 4 to -7

@DanRStevens DanRStevens Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to remove the branch filter. I usually have every branch build on push.

I don't normally bother with pull_request builds. They don't tend to be super useful if there is only a single development branch open at any given time, or only one developer actively working on a project. Assuming nothing has been merged to the base branch since the current branch was opened (or last rebased), a PR build won't really differ from a branch build. Additionally the PR builds don't start until a PR is opened, which means you have to wait for builds after opening a PR, whereas branch builds start earlier and are often done by the time a PR is opened.

Edit:
Also, when there are multiple branches open or multiple active developers on a project, PR builds tend to become stale anyway, especially if review takes awhile. I find rebasing a branch and relying on branch builds to be more reliable.


jobs:
build:
Expand All @@ -16,14 +14,14 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Clone Outpost2DLL dependency
run: |
git clone --depth 1 https://github.com/OutpostUniverse/Outpost2DLL ../Outpost2DLL

- name: Setup MSBuild
uses: microsoft/setup-msbuild@v1
uses: microsoft/setup-msbuild@v3

- name: Build OP2Helper
shell: cmd
Expand Down