Repository navigation
立绘差分功能 - #1034
立绘差分功能#1034
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89a2c17968
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| !!texture?.valid && | ||
| !texture.trim && | ||
| !texture.rotate && | ||
| texture.baseTexture.alphaMode !== ALPHA_MODES.NPM && |
There was a problem hiding this comment.
Permit default Pixi textures in the diff blend
For ordinary PNG/JPEG assets created through Texture.from, Pixi initializes BaseTexture.alphaMode to UNPACK, which is an alias of ALPHA_MODES.NPM. This condition therefore rejects the normal textures targeted by changeFigureDiff, causing prepareFigureDiff to return before creating the blend and silently use the ordinary replacement transition every time. The predicate must accept the default texture alpha mode or normalize it before testing.
Useful? React with 👍 / 👎.
Deploying webgal-dev with
|
| Latest commit: |
4fcbaed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a724f659.webgal-dev.pages.dev |
| Branch Preview URL: | https://fix-settimeout.webgal-dev.pages.dev |
支持切换立绘差分。要求使用切换立绘差分的独立脚本。本 PR 也同时清除了演出管理器中一些过时的 setTimeout 使用。
切换的差分需保证切换前后图像尺寸一致,否则走默认退出/进入效果。