Skip to content

立绘差分功能 - #1034

Merged
MakinoharaShoko merged 5 commits into
devfrom
fix-settimeout
Sep 23, 2026
Merged

MakinoharaShoko merged 5 commits into
devfrom
fix-settimeout

Conversation

@MakinoharaShoko

Copy link
Copy Markdown
Member

支持切换立绘差分。要求使用切换立绘差分的独立脚本。本 PR 也同时清除了演出管理器中一些过时的 setTimeout 使用。

切换的差分需保证切换前后图像尺寸一致,否则走默认退出/进入效果。

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89a2c17968

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

!!texture?.valid &&
!texture.trim &&
!texture.rotate &&
texture.baseTexture.alphaMode !== ALPHA_MODES.NPM &&

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Permit default Pixi textures in the diff blend

For ordinary PNG/JPEG assets created through Texture.from, Pixi initializes BaseTexture.alphaMode to UNPACK, which is an alias of ALPHA_MODES.NPM. This condition therefore rejects the normal textures targeted by changeFigureDiff, causing prepareFigureDiff to return before creating the blend and silently use the ordinary replacement transition every time. The predicate must accept the default texture alpha mode or normalize it before testing.

Useful? React with 👍 / 👎.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Deploying webgal-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fcbaed
Status: ✅  Deploy successful!
Preview URL: https://a724f659.webgal-dev.pages.dev
Branch Preview URL: https://fix-settimeout.webgal-dev.pages.dev

View logs

@MakinoharaShoko
MakinoharaShoko merged commit 8e088a6 into dev Sep 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant