Skip to content

Build the gemspec's file list without changing directory - #793

Merged
nmburgan merged 1 commit into
mainfrom
gemspec_without_chdir
Nov 16, 2026
Merged

nmburgan merged 1 commit into
mainfrom
gemspec_without_chdir

Conversation

@nmburgan

Copy link
Copy Markdown
Member

The openvox-agent package installs openvox.gemspec as the agent's installed gemspec, so RubyGems evaluates it when it loads the installed gems. Its Dir.chdir(dir) block changed back to the caller's directory when it ended, which fails for a user who can't enter that directory, and RubyGems then printed "Invalid gemspec" on stderr. Dir.glob with 'base: dir' lists the same files without changing directory.

The openvox-agent package installs openvox.gemspec as the agent's
installed gemspec, so RubyGems evaluates it when it loads the installed
gems. Its Dir.chdir(__dir__) block changed back to the caller's
directory when it ended, which fails for a user who can't enter that
directory, and RubyGems then printed "Invalid gemspec" on stderr.
Dir.glob with 'base: __dir__' lists the same files without changing directory.

Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
@nmburgan
nmburgan merged commit a31e44e into main Nov 16, 2026
22 checks passed
@nmburgan
nmburgan deleted the gemspec_without_chdir branch November 16, 2026 19:30
@bastelfreak bastelfreak added bug Something isn't working backport 8.x backports the merged PR to the 8.x branch labels Nov 16, 2026
@OpenVoxProjectBot

Copy link
Copy Markdown
Contributor

Backport failed for 8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 8.x
git worktree add -d .worktree/backport-793-to-8.x origin/8.x
cd .worktree/backport-793-to-8.x
git switch --create backport-793-to-8.x
git cherry-pick -x cea5f9474fc66d8e25fc2bfb74f219ac96b6c0ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 8.x backports the merged PR to the 8.x branch bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants