Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the empty newline after the body modifications.
@OpenVoxProject do you prefer the in-place
gsubcall?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muald I just learnt that in Ruby
RegExpthe anchors^and$match inmmode actually at the line boundaries and not at the string boundaries (according to the back of my head this used to be different... in Python). This means, due to the$anchor the match will definitely anchor at the end of the first line. As we want the whole first line gone, we then probably don't need the non-greedy?.But we definitely need the
mmode otherwise$would anchor at the end of the whole body string.We do leave an empty newline after the substitution.
Alternatively, without
mmode, we could also do this:This would remove only the whole first line of the body, if it starts with
Upgrades.@bastelfreak what do you think?