Repository navigation
Explain why Delete/Remove are disabled for the active database - #1082
Merged
Merged
Conversation
A newly created database becomes the active one right away, so "Delete permanently…" is disabled for it. The red stylesheet also overrode Qt's greyed disabled text, so the button looked clickable but did nothing. Add a tooltip pointing the user to switch databases first, and only apply the red colour when the button is enabled.
Member
|
Thanks @nagisml — small, clear fix. Scoping the red colour to Optional, not blocking: Delete is also disabled when the database file is missing on disk, and that case still has no tooltip. Could be a follow-up. Tests pass locally. Approving. |
Contributor
Author
|
@AgreeDK thanks for the review. missing on disk is fine to be added as I judge the risk as low I've included it in that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A newly created database becomes the active one right away, so "Delete permanently…" is disabled for it. The red stylesheet also overrode Qt's greyed disabled text, so the button looked clickable but did nothing. Add a tooltip pointing the user to switch databases first, and only apply the red colour when the button is enabled.
Closes #1081