Repository navigation
Conversation
Uncaught exceptions went to stderr, which a windowed build doesn't have, so they were lost, and a hard crash left no trace the user would find. - sys.excepthook / threading.excepthook log the traceback and show a "OpenSAK ran into a problem" dialog (Continue / Quit). Worker-thread exceptions are handed to the GUI thread through a queued signal. The same error shows the dialog only once per session. - faulthandler writes native crashes (segfaults in Qt/WebEngine) to crash_native.log. - A QLockFile session.lock is removed only on a clean exit. At the next start a lock left by a dead process means the last session crashed, and the user is offered a report with the native dump and the tail of opensak.log.previous. A second running instance is not taken for a crash. - The dialog shows the exact report text and can open a prefilled GitHub issue or a mail to hello@opensak.com, copy the report, or open the log folder so the log can be attached. Nothing is sent automatically; home paths, the user name, tokens and e-mail addresses are removed first. - New strings in all languages; tests in test_crash_report.py.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AgreeDK this is a proposal. Carefully judge provided options
Uncaught exceptions went to stderr, which a windowed build doesn't have, so they were lost, and a hard crash left no trace the user would find.