Repository navigation
GSAK import: drop separate filter-import menu entry, explain file types - #1067
Merged
AgreeDK merged 1 commit intoOct 16, 2026
Merged
Conversation
File → Import from GSAK Database already offers the saved GSAK filters (and user locations) whenever it finds a gsak.db3: inside a backup .zip, next to a chosen sqlite.db3, or chosen on its own. The separate File → Import GSAK Filters… entry did the same thing a second way, so it is removed. GsakFilterImportDialog stays, because the GSAK import still uses it for the filter step. - mainwindow: remove _act_gsak_filter_import and _open_gsak_filter_import_dialog - gsak_import_dialog: add an intro hint explaining what a backup .zip, a single sqlite.db3 and gsak.db3 alone each import - lang (all 11): add gsak_import_intro, drop action_gsak_filter_import - docs: filters.md and getting-started.md point to the GSAK import - e2e test: drive the filter import through the GSAK import with a bare gsak.db3; check that the old menu entry is gone and that gsak.db3 alone offers only filters and locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1066
Summary
File → Import from GSAK Database… already offers the saved GSAK filters and user locations whenever it finds a
gsak.db3. The separate File → Import GSAK Filters… entry did the same thing, so this PR removes it. The GSAK import dialog now has a short note at the top that says what each kind of file will import:.zip: lists all databases and offers the filters and user locations from itsgsak.db3.sqlite.db3: imports only that database. Filters and locations are also offered if agsak.db3is in its GSAK folder.gsak.db3alone: imports no caches, only the saved filters and user locations.GsakFilterImportDialogstays, because the GSAK import still opens it for the filter step.Changes
mainwindow.py: removed_act_gsak_filter_importand_open_gsak_filter_import_dialoggsak_import_dialog.py: added the intro notelang/*.py(all 11): addedgsak_import_intro, removedaction_gsak_filter_importdocs/filters.md,docs/getting-started.md: now point to the GSAK import for filterstest_e2e_gsak_filter_import.py: now runs the filter import through the GSAK import with a baregsak.db3. Added checks that the old menu entry is gone and thatgsak.db3alone offers only filters and locations.