Skip to content

pdftops: fix the printer make and model used for quirks #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tillkamppeter merged 1 commit into from
Nov 2, 2026
Merged

pdftops: fix the printer make and model used for quirks #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ppd/pdftops.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ ppdFilterPDFToPS(int inputfd, // I - File descriptor input stream
!strncasecmp(make, "Hewlett-Packard ", 16))
{
model = make + 16;
strncpy(make, "HP", sizeof(make));
memcpy(make, "HP", 3); // Not strncpy(), that would pad over the model
}
else if ((model = strchr(make, ' ')) != NULL)
*model++ = '\0';
Expand All @@ -456,7 +456,7 @@ ppdFilterPDFToPS(int inputfd, // I - File descriptor input stream
snprintf(make_model, sizeof(make_model), "%s %s", make, model);
}
}
else if (ppd)
else if (ppd && ppd->manufacturer && ppd->product && ppd->product[0])
{
snprintf(make_model, sizeof(make_model), "%s %s", ppd->manufacturer,
ppd->product + 1);
Expand Down
Loading