Repository navigation
Show the rejected device-uri in CUPS-Create-Local-Printer errors - #1782
Merged
michaelrsweet merged 1 commit intoOct 22, 2026
Merged
Conversation
create_local_printer() reported a bad device-uri with ptr, which at that point is left at the end of printer-name by the name sanitizing loop, so the message was always 'Bad device-uri "".'. Use device_uri_ptr like 2.4.x does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUPS-Create-Local-Printer with an unsupported device-uri always reports an empty URI:
The message uses
ptr, which by then has been walked to the end ofprinter-nameby the loop that sanitizes the queue name. 2.4.x passesdevice_uri_ptrhere; master switched toptrin 9fa1c04. This putsdevice_uri_ptrback, with a fallback to "" since that branch also runs when it is NULL.Tested against a local cupsd built from master, sending the request over the domain socket, before and after the change.