Skip to content

Tests: dispose every canvas a GUI test builds; classmethod qapp fixture #189

Closed

Description

@danyill

Two test-hygiene follow-ups from the #172/#176 CI work.

  1. About 40 tests/unit files build DiagramView() canvases without deleting them. A shown canvas left to the cyclic collector has its scene, items and cursors torn down in an unsafe order and segfaults in gc.collect() (tests/conftest.py _test_hygiene). It already hit test_gui_tool_cursor.py and test_routing_nodes.py, which got per-file fixes. A shared step in the hygiene fixture should cover the rest.
  2. PytestRemovedIn10Warning: the module-scoped qapp fixture in tests/unit/test_start_to_end_and_units.py is an instance method.

Activity

  1. danyill commented on Nov 8, 2026

    @danyill
    ContributorAuthor

    Fixed by #190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions