Skip to content

Calibration ignores the units of data and targets #1680

Open

Description

@adrpo

Description

The calibration reads units but never uses them:

  • ObservedVariable.unit and CalibrationTarget.unit are read from the UQ file, and
  • a reference data column header may carry a unit (name|unit, e.g. level_3_dc_motor.nRPM|rev/min), which is only used to find the column.

The CSV values are compared with the model values as they are. A rev/min column against a model speed in rad/s, or bounds of a target given in another unit than the FMU's, silently give a wrong fit.

Expected

Convert reference data and target bounds/initial values to the units of the model variables (SI + the usual Modelica display units), and stop with an error naming the variable when a unit cannot be converted.

Related

Follow-up of #1674 / #1675.


🤖 Generated with Claude Code

Activity

  1. self-assigned this
    on Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions