Repository navigation
Skip and report libraries that fail instead of aborting the index - #94
Merged
Merged
Conversation
…enModelica#61) genindex raised on a rawdata.json ref without libraries (LEPSE v1.2.1) and stopped the whole "Update Package Index" job. It now leaves that ref out of the index and goes on with the others. updateinfo and genindex write what they skipped to updateinfo-problems.txt and genindex-problems.txt (libraries that did not load, refs kept from or dropped from the previous run, repositories that could not be fetched, duplicate library files). The Jenkinsfile marks the job unstable when either file exists and mails the list to PROBLEMS_EMAIL (default adrian.pop@liu.se, empty sends nothing). Fixes OpenModelica#61 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AnHeuermann
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61
A library that cannot be handled no longer stops "Update Package Index". It is left out, listed, and the job goes unstable and sends the list by mail.
Changes
rawdata.jsonref without libraries (theException: LEPSE v1.2.1in Handle libraries that fail to parse #61) is left out of the index with a warning. It no longer raises.updateinfo-problems.txt/genindex-problems.txtthroughcommon.write_problems. The file is removed after a clean run so a stale list never outlives it.unstable(...)andemailextsends the list plus the console link to the newPROBLEMS_EMAILparameter (defaultadrian.pop@liu.se; empty sends no mail).Tests
tests/test_problems.py:write_problems: writing the list, and removing a stale filegenindex.mainon arawdata.jsonwith a libless ref: it is skipped fromindex.jsonand reportedload_libraryrecords the omc error of a library that does not loadLocally all 41 tests pass except
test_run_check_missing, which needsGITHUB_AUTH(set in CI). The Jenkinsfile change can only be checked by a run on Jenkins.generated by Claude Code
🤖 Generated with Claude Code