Skip to content

Feature 49 improved datapackage tests - #326

Open
Cpprentice wants to merge 7 commits into
developfrom
feature-49-improved-datapackage-tests
Open

Cpprentice wants to merge 7 commits into
developfrom
feature-49-improved-datapackage-tests

Conversation

@Cpprentice

@Cpprentice Cpprentice commented Oct 8, 2026 •

Copy link
Copy Markdown

Summary of the discussion

Shall close #49 and #316

Type of change (CHANGELOG.md)

Added

Changed

Workflow checklist

Automation

Closes #49
Closes #316

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Cpprentice
Cpprentice requested a review from jh-RLI October 8, 2026 13:15
@Cpprentice Cpprentice linked an issue Oct 8, 2026 that may be closed by this pull request
1 task done

@jh-RLI jh-RLI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLs check why the tests fail :)

@Cpprentice

Copy link
Copy Markdown
Author

PLs check why the tests fail :)

Was more tricky than I thought. PyLD is more stict in the latest version, and that failed with my invalid approach of locally injecting the context into the JSON.

Should be fixed now.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise and update tests Add tests that validates OEMetadata as datapackage compatible

2 participants