Repository navigation
Conversation
Clearing the proxy GATT cache is best effort, but a proxy that was slow to answer raised a bare TimeoutError and aborted the update. A BLETimeoutError during the app-mode trigger also escaped the handler that already tolerates a failed connect and flashes through the AppLoader directly. Handle both, and report a timeout during the flash as a failed update. Refs OpenDisplay#69 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kbaker827
force-pushed
the
fix/69-silabs-ota-timeouts
branch
from
November 6, 2026 16:13
615a983 to
3825d19
Compare
Author
|
CI is waiting on maintainer approval here, so I ran the workflows on my fork at
This covers this branch on its own, not merged with the other open PRs, and nothing has been run on real hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #69
Summary
From the traceback on #69:
TimeoutErrorand aborted the update. It is now logged and the update continues.BLETimeoutErroris not aBLEConnectionError, so it escaped the handler that already tolerates a failed app-mode connect and flashes through the AppLoader. It now takes that path.BLETimeoutErrorduring the flash now reports as a failed update, not an unexpected error.The OTA deadline still fires:
asyncio.timeoutraisesCancelledErrorinside the await, so the new innerexcept TimeoutErrorcannot swallow it.Test plan
🤖 Generated with Claude Code