Repository navigation
Conversation
A transparent area came out as whatever colour the encoder left beneath it, usually black, on the preview always and on the panel for grayscale and indexed files. Flatten on white when loading, and in the preview encoder so a transparent drawcustom canvas matches too. Source images with a wide-gamut profile were quantized by their raw values against palettes defined in sRGB. Convert them when loading, which corrects the panel and the preview together. An unreadable profile is logged and the image still goes out. A dlimg in drawcustom is loaded by odl-renderer, so its colour profile is not converted here. Fixes OpenDisplay#77 Refs OpenDisplay#73 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
CI is waiting on maintainer approval here, so I ran the workflows on my fork at
This covers this branch on its own, not merged with the other open PRs, and nothing has been run on real hardware. |
Member
|
Fixed in library, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77
Refs #73
Summary
drawcustomcanvas matches too.ImageCmsis imported inside the function so a Pillow build without LittleCMS cannot stop the integration from importing.Not covered
dlimgindrawcustomis loaded byodl-renderer, so Source images with a non-sRGB ICC profile are pushed unconverted (Adobe RGB / Display P3) #73 stays open for that half.Evidence
On the Adobe RGB photo from #73, mean difference from Unsplash's own
cs=srgbrender fell from 7.27 to 1.25 (per channel, 0-255).Test plan
tests/test_image_loading.py, using a real Adobe RGB profile; the behaviour tests failed before the change🤖 Generated with Claude Code