Repository navigation
Conversation
The action editor can deliver an unquoted y: 10 as true: 10, so the element reached the renderer with no y at all: text stacked at the top, and elements that require y failed. Rename that key back to y during validation. An explicit y wins if both are present. Fixes OpenDisplay#97 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
CI is waiting on maintainer approval here, so I ran the workflows on my fork at
This covers this branch on its own, not merged with the other open PRs, and nothing has been run on real hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
Summary
The action editor can deliver an unquoted
y: 10astrue: 10(visible in the YAML in #108 and in the comments on #97), so the element reached the renderer with noy: text stacked at the top, and elements that requireyfailed. This renames that key back toyduring validation. An explicitywins if both are present, and values oftrueunder other keys are untouched.A comment on #97 says
dlimgfailed even with a quotedy. I couldn't reproduce that: the real renderer draws adlimgcorrectly when it has ay, using a data URI source.Only top-level element keys are repaired, which is where the renderer reads
y.Test plan
This and the #140 PR both append tests to the end of
tests/test_services.py, so whichever merges second has a small conflict to resolve (keep both blocks).🤖 Generated with Claude Code