Repository navigation
Conversation
The library uploads with FULL whenever it receives a PartialState, and the integration always passed one, so a requested fast refresh became a full one with no warning. Pass no state for FAST, on both live and queued delivery. Fixes OpenDisplay#140 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
CI is waiting on maintainer approval here, so I ran the workflows on my fork at
This covers this branch on its own, not merged with the other open PRs, and nothing has been run on real hardware. |
Member
|
This fix belonged in the library, not the integration. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140
Summary
upload_prepared_imageuploads with FULL whenever it receives aPartialState, and the integration always passed one, sorefresh_type: fastsilently became a full refresh. This passes no state for FAST, on both live and queued delivery.After a FAST refresh the tracked state is empty, so the next
partialfalls back to one full refresh (compute_partial_regionreturnsfallback_full) and re-baselines the panel.Also adds
partialto therefresh_typedocs, with its 1-bit limitation.Test plan
🤖 Generated with Claude Code