Skip to content

fix: send refresh_type fast to the device as FAST - #156

Closed
kbaker827 wants to merge 1 commit into
OpenDisplay:mainfrom
kbaker827:fix/140-honor-fast-refresh
Closed

kbaker827 wants to merge 1 commit into
OpenDisplay:mainfrom
kbaker827:fix/140-honor-fast-refresh

Conversation

@kbaker827

Copy link
Copy Markdown

Fixes #140

Summary

upload_prepared_image uploads with FULL whenever it receives a PartialState, and the integration always passed one, so refresh_type: fast silently became a full refresh. This passes no state for FAST, on both live and queued delivery.

After a FAST refresh the tracked state is empty, so the next partial falls back to one full refresh (compute_partial_region returns fallback_full) and re-baselines the panel.

Also adds partial to the refresh_type docs, with its 1-bit limitation.

Test plan

  • New tests for FAST by name and legacy number, and that full and partial still track state; the FAST tests failed before the change
  • Full suite passes. Run locally on Windows with small local stand-ins for the Unix and BlueZ modules Home Assistant needs (not part of this PR), so CI on Linux is the first clean run.
  • Not run on a real panel: please confirm a visible fast refresh, and a partial following it

🤖 Generated with Claude Code

The library uploads with FULL whenever it receives a PartialState, and the integration always passed one, so a requested fast refresh became a full one with no warning. Pass no state for FAST, on both live and queued delivery.

Fixes OpenDisplay#140

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kbaker827
kbaker827 requested a review from g4bri3lDev as a code owner November 6, 2026 16:12
@kbaker827

Copy link
Copy Markdown
Author

CI is waiting on maintainer approval here, so I ran the workflows on my fork at 21d2aa0:

  • Tests: passed, on both the latest and min-ha Home Assistant, plus ruff
  • hassfest: passed
  • HACS: 8 of 10 checks passed. The two failures are fork settings (issues disabled, no topics), and the fork's unmodified main fails the same two.

This covers this branch on its own, not merged with the other open PRs, and nothing has been run on real hardware.

@g4bri3lDev

Copy link
Copy Markdown
Member

This fix belonged in the library, not the integration. closing

@g4bri3lDev g4bri3lDev closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refresh_type: fast silently becomes a full refresh

2 participants