Repository navigation
Conversation
py-opendisplay imports DbsParams from epaper_dithering at module scope. Home Assistant only checks requirements the manifest names, so when another install leaves an older epaper-dithering behind, py-opendisplay still looks satisfied, nothing reinstalls it, and the integration fails to import. Naming it makes the requirement check fail and reinstall it before import. Fixes OpenDisplay#154 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
CI is waiting on maintainer approval here, so I ran the workflows on my fork at
This covers this branch on its own, not merged with the other open PRs, and nothing has been run on real hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154
Summary
py-opendisplayimportsDbsParamsfromepaper_ditheringat module scope. Home Assistant only checks requirements the manifest names, not their transitive dependencies. So with an olderepaper-ditheringinstalled,py-opendisplay>=7.18.1still looks satisfied, nothing reinstalls it, and the integration fails to import.Naming
epaper-dithering>=6.1.1in the manifest makes that check fail, andasync_process_deps_reqsreinstalls it before the import, both at setup and for config flows.Evidence
In a clean venv with
py-opendisplay==7.18.1andepaper-dithering==6.0.0:import opendisplayraises the sameImportErroras the reportpy-opendisplay>=7.18.1and failsepaper-dithering>=6.1.1epaper-dithering>=6.1.1makes the import succeedI don't know what downgraded the package on the reporter's system. This repairs the state regardless, but if another integration pins an older version, the two could keep overwriting each other across restarts.
Test plan
tests/test_manifest.py, failed before the change🤖 Generated with Claude Code