[Raymond-MS]

Description

Updated the TPM service to include changes from the most recent v1.1 CRB Over FF-A specification. This includes the changes to manage_locality and the addition of get_crb_info. Updated the TPM service to allow for all registers to be accessible. This was needed for get_crb_info. Added tests for get_crb_info and updated the tests for manage_locality. The changes to only allow opening/closing locality2/3 required changes to other tests as well which were opening and closing locality0. Updated the mod.rs file to expose the TPM SST which will allow other developers including the TPM service to provide their own implementation of the TPM SST. Updated Safety comments. Fixed Clippy issues.

• Impacts functionality?
• Impacts security?
• Breaking change?
• Includes tests?
• Includes documentation?

How This Was Tested

Ran all UnitTests

Integration Instructions

N/A

[Copilot]

🟡 Changes recommended

The reported interface version and CRB control address are incorrect for v1.1 clients.

5 open findings

• Bump TPM minor version to 1 for new v1.1 functions · New
• Return the CRB control area address from GET_CRB_INFO · New
• Validate locality before narrowing it to u8 · New
• End the payload register range at Arg13 · New
• Fix plural agreement for the two localities · New

What changed in this PR

Updates the TPM service for CRB over FF-A v1.1 and enables custom SST implementations.

Changes:

• Adds GetCrbInfo and revised locality management.
• Expands response payloads to all FF-A registers.
• Exposes SST interfaces and updates safety documentation/tests.

File	Description
ec-service-lib/​src/​services/​tpm.rs	Implements v1.1 operations and tests.
ec-service-lib/​src/​services/​tpm_sst.rs	Strengthens SST safety contracts.
ec-service-lib/​src/​services/​mod.rs	Exports SST extension types.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

The invalid-operation test now passes through locality validation without testing its intended branch.

0 open findings

5 resolved since last review

• Validate locality before narrowing it to u8
• Return the CRB control area address from GET_CRB_INFO
• Bump TPM minor version to 1 for new v1.1 functions
• Fix plural agreement for the two localities
• End the payload register range at Arg13

Previously missed (1)

In code that hasn't changed since last review

Update test locality to reach invalid-operation validation

ec-service-lib/​src/​services/​tpm.rs:620

The new early locality check means test_manage_locality_invalid_function (which sends locality 0) now returns InvArg here, before reaching the invalid-operation branch. Change that test to use locality 2 or 3 so it still verifies operation validation rather than passing for the wrong reason.

🧠 Review effort: Balanced

[Raymond-MS]

@dymk @philgweber Could I get a review on this please? It has been up for a couple weeks now.

@kuqin12 If you have time, I would like you to take a quick look as well.

Thanks!