Repository navigation
Widen webmozart/assert constraint to allow ^2.0 - #32
Open
kayjoosten wants to merge 1 commit into
Open
kayjoosten wants to merge 1 commit into
kayjoosten wants to merge 1 commit into
Conversation
# If applied, this commit will allow consumers of this bundle to # upgrade webmozart/assert to version 2.x without a dependency conflict. # Why is this change needed? Prior to this change, the hard pin on webmozart/assert ^1.10 blocked downstream projects (e.g. OpenConext-engineblock) from upgrading simplesamlphp/assert and simplesamlphp/saml2-legacy, both of which require webmozart/assert ~2.1 or ^2.0, holding back security fixes further down the dependency tree. # How does it address the issue? This change widens the constraint to ^1.10|^2.0. The bundle only uses Assert::stringNotEmpty(), which is unchanged between major versions, so no source changes are required. Verified with the full local test suite (docheader, phpcs, phpcpd, phpunit, phpmd) against both the previous and the new webmozart/assert version. # Provide links to any relevant tickets, articles or other resources Related to OpenConext/OpenConext-engineblock#2048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If applied, this PR will
allow consumers of this bundle to upgrade webmozart/assert to version 2.x without a dependency conflict.
Why is this change needed?
Prior to this change, the hard pin on webmozart/assert ^1.10 blocked downstream projects (e.g. OpenConext-engineblock) from upgrading simplesamlphp/assert and simplesamlphp/saml2-legacy, both of which require webmozart/assert ~2.1 or ^2.0, holding back security fixes further down the dependency tree.
How does it address the issue?
This change widens the constraint to ^1.10|^2.0. The bundle only uses Assert::stringNotEmpty(), which is unchanged between major versions, so no source changes are required. Verified with the full local test suite (docheader, phpcs, phpcpd, phpunit, phpmd) against both the previous and the new webmozart/assert version.
Provide links to any relevant tickets, articles or other resources
Related to OpenConext/OpenConext-engineblock#2048