Repository navigation
feat(validation): ship read-only endpoint access checks - #83
Merged
Merged
Conversation
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
27 tasks
synackd
reviewed
Nov 6, 2026
synackd
reviewed
Nov 6, 2026
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
synackd
reviewed
Nov 6, 2026
synackd
reviewed
Nov 6, 2026
synackd
previously approved these changes
Nov 6, 2026
synackd
left a comment
Contributor
There was a problem hiding this comment.
Two wording nits, but overall looks good. Approving with rewording comments. Tested manually.
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
synackd
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the new read-only
openchami-validate-endpointstool and associated versioned endpoint validation policies to the OpenCHAMI RPM. It updates packaging, documentation, and the test workflow to support endpoint validation and comparison before and after upgrades. The validator is explicitly run by operators and does not change service state, but provides structured evidence of endpoint and JWT access policy. Documentation is added to guide usage and interpretation.Endpoint validation tooling and policies:
openchami-validate-endpointsscript to the RPM and ensured it is installed into/usr/bin/along with versioned JSON policies under/usr/share/openchami/validation/policies/. [1] [2]python3as a required dependency for the validator tool.docs/endpoint-validation.mddescribing the validator, its usage, policy schema, and upgrade workflow.README.mdanddocs/metadata-security.mdto reference the new endpoint validator and its role in upgrade and security verification. [1] [2]Packaging and licensing:
openchami.specto include the validator tool and policies, and to install related documentation and license files. [1] [2]LICENSES/MIT.txt.Test and workflow updates:
test-validatortarget to theMakefilefor running endpoint validation tests, and updated.PHONYaccordingly. [1] [2]Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change