Repository navigation
Conversation
This applies OpenCCU rootfs patch 0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patch: - Add "white-space: break-spaces" to .CLASS02535, the value column of the system variable lists, so consecutive spaces in string values are shown instead of being collapsed into one.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
@coderabbitai Review |
✅ Action performedReview finished.
|
This removes OpenCCU rootfs patch 0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patch, now that OpenCCU/OpenCCU-Base#204 is merged.
Original OpenCCU rootfs patch: 0124
Original filename:
0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patchOriginal patch: ``''
https://github.com/OpenCCU/OpenCCU/blob/416b9de18af2723643c030d1671900727d71a4a0/buildroot-external/package/openccu-base/rootfs-patches/0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patch''''Original changes: OpenCCU/OpenCCU@6bae3a0dc (OpenCCU/OpenCCU#1310, OpenCCU/OpenCCU#1311) and OpenCCU/OpenCCU@acf3b8643 (CSS instead of
replacement)String system variables with several consecutive spaces are shown with the spaces collapsed into one, because HTML collapses white space. This applies the patch 1:1:
src/webui/www_source/webui/css/x_style.css:.CLASS02535getswhite-space: break-spaces;. This class is the value<span>of system variables indatapointconfigurator.fn, so consecutive spaces are preserved while long values still wrap.x_style.csskeeps its CRLF line endings. The rootwww/copies are unused legacy files and are left unchanged.Workspaces of the earlier OpenCCU patches
OpenCCU rootfs patch 0039 (style glitches) rewrites the whole
.CLASS02535block and uses its closing}as context, so it no longer applies with zero fuzz on top of this change. Like OpenCCU/OpenCCU#4325, the OpenCCU cleanup PR will add thewhite-space: break-spaces;line to thestyle.cssworkspaces (.origand modified file) of the earlier patches 0029, 0039, 0046, 0056, 0057, 0061, 0095, 0099 and 0122 and regenerate them. Patch 0039 then changes in this one context line, 0046 and 0061 only in hunk line numbers; all other patches are unchanged. Until that cleanup is merged, OpenCCU must not be bumped to a Base revision containing this change.Validation
x_style.cssdirectly;git diff --check(withcr-at-eol) is clean.scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (d63adaef, sha2562e9298d7315622f9674a945feb5f865b03da08dafc468bf0f85e7096ed33fc50) and--skip-patch 0124, on OpenCCUmaster416b9de18(current pin0b46b1a1) with the refreshed workspaces described above: PASS (the other 50 rootfs patches apply with zero fuzz).comparerefuses this case because patches 0039, 0046 and 0061 change in context and line numbers. The validation manifest (file types, modes and hashes of all 4666 entries) is therefore compared directly with a validation of the current pin0b46b1a1with all 51 patches: byte-identical. The same holds for this change applied directly on the pin0b46b1a1(without hss_led: report an active disableLED lock in the radio LED status #203).OpenCCU cleanup PR (removing patch 0124, refreshing the earlier workspaces and updating the pin): OpenCCU/OpenCCU#4452
Generated by Claude Code
Summary by CodeRabbit
Generated by Claude Code