Skip to content

webui: show multiple spaces in system variable values - #204

Merged
jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0124-webui-fix-show-multiple-spaces-in-sysvar
Oct 16, 2026
Merged

jens-maus merged 1 commit into
mainfrom
jens-maus/migrate-0124-webui-fix-show-multiple-spaces-in-sysvar

Conversation

@jens-maus

@jens-maus jens-maus commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Original OpenCCU rootfs patch: 0124
Original filename: 0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patch
Original patch: ``''https://github.com/OpenCCU/OpenCCU/blob/416b9de18af2723643c030d1671900727d71a4a0/buildroot-external/package/openccu-base/rootfs-patches/0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patch''''
Original changes: OpenCCU/OpenCCU@6bae3a0dc (OpenCCU/OpenCCU#1310, OpenCCU/OpenCCU#1311) and OpenCCU/OpenCCU@acf3b8643 (CSS instead of   replacement)

String system variables with several consecutive spaces are shown with the spaces collapsed into one, because HTML collapses white space. This applies the patch 1:1:

  • src/webui/www_source/webui/css/x_style.css: .CLASS02535 gets white-space: break-spaces;. This class is the value <span> of system variables in datapointconfigurator.fn, so consecutive spaces are preserved while long values still wrap.

x_style.css keeps its CRLF line endings. The root www/ copies are unused legacy files and are left unchanged.

Workspaces of the earlier OpenCCU patches

OpenCCU rootfs patch 0039 (style glitches) rewrites the whole .CLASS02535 block and uses its closing } as context, so it no longer applies with zero fuzz on top of this change. Like OpenCCU/OpenCCU#4325, the OpenCCU cleanup PR will add the white-space: break-spaces; line to the style.css workspaces (.orig and modified file) of the earlier patches 0029, 0039, 0046, 0056, 0057, 0061, 0095, 0099 and 0122 and regenerate them. Patch 0039 then changes in this one context line, 0046 and 0061 only in hunk line numbers; all other patches are unchanged. Until that cleanup is merged, OpenCCU must not be bumped to a Base revision containing this change.

Validation

  • The change was applied to x_style.css directly; git diff --check (with cr-at-eol) is clean.
  • OpenCCU scripts/base-patch-migration.py validate with the canonical Buildroot 2026.08 git4 archive of this branch (d63adaef, sha256 2e9298d7315622f9674a945feb5f865b03da08dafc468bf0f85e7096ed33fc50) and --skip-patch 0124, on OpenCCU master 416b9de18 (current pin 0b46b1a1) with the refreshed workspaces described above: PASS (the other 50 rootfs patches apply with zero fuzz).
  • compare refuses this case because patches 0039, 0046 and 0061 change in context and line numbers. The validation manifest (file types, modes and hashes of all 4666 entries) is therefore compared directly with a validation of the current pin 0b46b1a1 with all 51 patches: byte-identical. The same holds for this change applied directly on the pin 0b46b1a1 (without hss_led: report an active disableLED lock in the radio LED status #203).

OpenCCU cleanup PR (removing patch 0124, refreshing the earlier workspaces and updating the pin): OpenCCU/OpenCCU#4452


Generated by Claude Code

Summary by CodeRabbit

  • Style
    • Whitespace in the affected content is now preserved while still wrapping onto new lines.

Generated by Claude Code

This applies OpenCCU rootfs patch 0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patch:

- Add "white-space: break-spaces" to .CLASS02535, the value column of
  the system variable lists, so consecutive spaces in string values are
  shown instead of being collapsed into one.
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 24efd334-e714-4845-a13f-535b61c4105e
📥 Commits

Reviewing files that changed from the base of the PR and between fb58999 and d63adae.

📒 Files selected for processing: 1
  • src/webui/www_source/webui/css/x_style.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The CLASS02535 CSS rule now applies white-space: break-spaces. Its existing word-wrapping and inline-block declarations remain.

Changes: CLASS02535 whitespace rendering

Layer / File(s) Summary
Update CLASS02535 whitespace behavior
src/webui/www_source/webui/css/x_style.css
CLASS02535 adds white-space: break-spaces and retains its existing word-wrapping and inline-block declarations.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d63ad

Repeated spaces in system-variable values can remain visible while long values still wrap. The supplied change context indicates no material merge risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: preserving multiple spaces in system variable values in the WebUI.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus

Copy link
Copy Markdown
Member Author

@coderabbitai Review

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jens-maus
jens-maus merged commit c9553f9 into main Oct 16, 2026
5 checks passed
@jens-maus
jens-maus deleted the jens-maus/migrate-0124-webui-fix-show-multiple-spaces-in-sysvar branch October 16, 2026 07:52
jens-maus added a commit to OpenCCU/OpenCCU that referenced this pull request Oct 16, 2026
This removes OpenCCU rootfs patch 0124-WebUI-Fix-ShowMultipleSpacesInSysVar.patch, now that OpenCCU/OpenCCU-Base#204 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant