Skip to content

Fix issue #243 - #244

Merged
lohedges merged 3 commits into
develfrom
fix_243
Oct 12, 2026
Merged

lohedges merged 3 commits into
develfrom
fix_243

Conversation

@lohedges

Copy link
Copy Markdown
Contributor

Closes #243. The GCMC end-state topologies, which include the additional waters, were only written at the final checkpoint, so the output directory held a topology without them for the whole run. That didn't match the trajectory or checkpoints of a run in progress or one that had crashed. They're now written at the first checkpoint of each run, using a flag rather than the block number so that restarts are covered too (the cause of #87), and again at the final checkpoint so that the PDB files hold the final coordinates. A GCMC restart also no longer overwrites existing topologies with ones that lack the extra waters, which previously happened when a restarted run never reached a checkpoint, e.g. because every window was already complete. Additionally, the PME parameters read on restart are now logged in the same format as when they're tuned, rather than at full precision.

@lohedges
lohedges deployed to somd2-build October 12, 2026 09:25 — with GitHub Actions Active
@lohedges
lohedges deployed to somd2-build October 12, 2026 09:25 — with GitHub Actions Active
@lohedges
lohedges deployed to somd2-build October 12, 2026 09:25 — with GitHub Actions Active
@lohedges
lohedges deployed to somd2-build October 12, 2026 09:25 — with GitHub Actions Active
@lohedges
lohedges merged commit 5a521bc into devel Oct 12, 2026
4 checks passed
@lohedges
lohedges deleted the fix_243 branch October 12, 2026 09:37

This branch was successfully deployed

1 active deployment
somd2-build — 2b7fa489 Deployed Oct 12, 2026 by lohedges via build (3.10, linux) #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCMC topology is only written at the final checkpoint

1 participant