Repository navigation
Conversation
lohedges
had a problem deploying
to
somd2-build
October 12, 2026 09:12 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
somd2-build
October 12, 2026 09:12 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
somd2-build
October 12, 2026 09:12 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243. The GCMC end-state topologies, which include the additional waters, were only written at the final checkpoint, so the output directory held a topology without them for the whole run. That didn't match the trajectory or checkpoints of a run in progress or one that had crashed. They're now written at the first checkpoint of each run, using a flag rather than the block number so that restarts are covered too (the cause of #87), and again at the final checkpoint so that the PDB files hold the final coordinates. A GCMC restart also no longer overwrites existing topologies with ones that lack the extra waters, which previously happened when a restarted run never reached a checkpoint, e.g. because every window was already complete. Additionally, the PME parameters read on restart are now logged in the same format as when they're tuned, rather than at full precision.