Repository navigation
fix(chat): keep conversation history starting on a user turn - #655
Open
subidhkhanal wants to merge 1 commit into
Open
subidhkhanal wants to merge 1 commit into
subidhkhanal wants to merge 1 commit into
Conversation
Contributor
|
@subidhkhanal is attempting to deploy a commit to the allan-feng's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug. The chat keeps the last 12 messages (6 questions and 6 answers). On the 7th question it cuts the history from the front, but only one message is removed: the oldest question. Its answer stays at the top. So from the 7th message on, the model receives a conversation that opens with an answer to a question it never saw.
Why it matters. It doesn't throw an error, which is why nobody noticed. It silently makes answers worse in any chat longer than 6 messages. I checked this with one real request to Anthropic in the same shape (
[assistant: "Yes, I sold it.", user: "Why?"]). The API accepted it, and the model replied "I don't have context for…". Anthropic's docs also say the first message should be from the user. I couldn't test the CommonStack route used in production (no key), so its exact behaviour is unverified, but the model gets the same broken context either way.The failure path had the same problem: after a failed request, the history could be left starting with an answer.
The fix (
domain/chat/service.py). A small helper,_trim_history, keeps the last 12 messages and then drops any answer left at the front. In effect, the oldest question and its answer are removed together. It replaces both places that trimmed the history.Tests (
tests/domain/chat/test_service.py):a1first).