Repository navigation
docs: fix architecture drift in CLAUDE.md and user docs - #652
Merged
Merged
Conversation
CLAUDE.md: correct the LLM safety boundary (validate_llm_response is on no production path), the store-twin counts (13 pairs, trace twin now built in a backtest child), what USERS_/CONTENT_DATABASE_URL carry, the domain/trading label, missing surfaces (Robinhood, Trading Algo, research, iFinD), LLM spend that bypasses Credits, and drifted line anchors (now function names). User docs: drop "paper trading is coming" promises, the PyPI SDK and "open leaderboard" claims and the live-news claim; redraw lab/architecture.rst. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Real capital is out of scope (2026-10-14 direction). Drop it from the README key features, key_features.rst, the docs index lead and getting started. live_trading.rst stays as the reference for the agent editor's panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- LLM safety boundary: a billed (fail_closed) run aborts on the first unparseable reply; strikes apply to strict runs without a handoff. Name the post-trade prompt-patch channel and the Trading Algo backtest loop, which bypasses extract_response_text, parse_llm_response and MAX_ORDER_SHARES. Point the limits at SECURITY.md as the one table and bring that table up to date. - Operator-billed LLM list: add the Trading Algo backtest's per-bar calls and the Discord bot's chat. - ATL_BACKTEST_WORKER: re-measure the child's twins (7 twins, 117 statements over 7 checkouts) and add the trace store's run-time route. - Robinhood: list the five places that stay as reference, and fix the claim that the docs index leaves it out. - architecture.rst: storage reached from the API too, Yahoo Finance as a data source, and which settings hold stored secrets. - README and /app: drop the hidden portfolio feature and the paper trading "coming soon" promise. fix(algo): hold execute_algo's single-flight check under a lock. The route is a sync def, so two concurrent POSTs could both pass the unlocked check and each start a subprocess on the platform key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every correction below was checked against the code at
d3cfc33d.CLAUDE.md
validate_llm_responseruns only inllm_integration_example.pyand tests. The section now names what actually holds: no LLM request sends tools, non-text blocks are dropped, parsing is strict, and the portfolio manager caps orders. It also names the Robinhood gates._TWINS.USERS_DATABASE_URLalso carries Credits (purchases included), provider keys and analytics.CONTENT_DATABASE_URLalso carries agent credentials and research runs. The broker store reads both.domain/tradingis the backtest fill and valuation helpers, not live trading. The missing pieces are added: credits, model_providers, analytics, traces and brokers; the Robinhood live path; and the Trading Algo, research and iFinD surfaces.MAX_ACTIVE_DASHBOARD_BACKTESTSdoes not count the Trading Algo subprocess.User docs
index.rst,lab/{index,overview,operating_modes,live_trading,accounts,marketplace,getting_started}.rstand the SDK README. The 2026-10-14 direction puts broker paper trading out of scope.lab/architecture.rst. The diagram is redrawn as Vercel → API → worker → stores. The page adds a storage section and the research and Robinhood routes.key_features.rst, thelab/index.rstlead and getting started, since real capital is out of scope.live_trading.rst, theoperating_modesentry (P7's rename text points at it) and the API table row stay as reference, because the agent editor still shows the panel. CLAUDE.md records the rule.Left alone on purpose
Review follow-up (
f4aa2aad, after mergingmain)execute_algonow holds its single-flight check under_launch_lock. The route is a syncdef, so two concurrent POSTs could both pass the unlocked check and each start a subprocess on the platform key.test_concurrent_executes_start_one_runfails without the lock.MAX_ORDER_SHARES.SECURITY.mdholds the one constraint table, now current.architecture.rstadds API→storage, Yahoo Finance and where stored secrets live. The README drops the hidden portfolio feature./appsays paper trading is "not available" instead of "coming soon". CLAUDE.md lists the five Robinhood references that stay.test_report_pdf(reportlabis not installed locally).🤖 Generated with Claude Code