Repository navigation
Target net8.0 for the Halibut library - #727
Closed
LukeButters wants to merge 3 commits into
Closed
LukeButters wants to merge 3 commits into
LukeButters wants to merge 3 commits into
Conversation
…e) can use it Tests and build tooling remain on net10.0. CompileDotNet now builds only the test project for net10.0 since the library no longer has a net10.0 target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentacle consumes the Halibut NuGet package but runs on net8, so the library now targets
net48;net8.0instead ofnet48;net10.0. The target framework is the minimum supported version; net10 hosts load net8 libraries fine.Halibut.csproj:net10.0->net8.0(including framework-conditioned items/constants)Build.cs:CompileDotNetbuildsHalibut.Testsfor net10.0 rather than the whole solution with-f net10.0(which failed with NETSDK1005 as the library has no net10.0 target)Tests and build tooling remain on net10.0, and the SDK is still 10.0.401 via global.json.