Skip to content

Redis bump #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sburmanoctopus merged 1 commit into from
Oct 5, 2026
Merged

Redis bump #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/RunningRedisLocally.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ docker run -d --rm --name halibut-redis \
--tmpfs /data \
--tmpfs /tmp \
-v `pwd`/redis-conf:/etc/redis:ro \
redis:8.0.3 \
redis:8.10.1 \
/etc/redis/redis.conf --requirepass halibut-local-redis
```

Expand All @@ -33,7 +33,7 @@ This is how we recommend running Redis for the queue. Only the config file and t
| `--tmpfs /data` | `/data` is Redis's working directory (`dir /data` in `redis.conf`). With `--read-only` it needs a writable directory, and tmpfs keeps it in memory so nothing is ever written to disk. That way Redis never stores any data (see above). | Yes if you use `--read-only`. |
| `--tmpfs /tmp` | Gives Redis writable scratch space in memory, since the root filesystem is read-only. | Yes if you use `--read-only`. |
| ``-v `pwd`/redis-conf:/etc/redis:ro`` | Mounts `redis-conf/redis.conf` read-only. This is where persistence is turned off. The user Redis runs as (see `--user`) must be able to read this file, otherwise Redis fails to start. | Yes. |
| `redis:8.0.3` | The Redis version the queue is tested against. | No, but recommended. |
| `redis:8.10.1` | The Redis version the queue is tested against. | No, but recommended. |
| `/etc/redis/redis.conf` | Tells Redis to use the mounted config file. | Yes. |
| `--requirepass halibut-local-redis` | Requires clients to authenticate. `halibut-local-redis` is the password the tests look for by default. | No, but recommended. |

Expand Down
4 changes: 2 additions & 2 deletions source/Halibut.Tests/Queue/Redis/Utils/RedisContainerBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ public class RedisContainerBuilder
{
// Octopus Cloud runs octopusdeploy/dhi-redis (a Docker Hardened Image), which needs registry credentials to pull.
// This is the public image of the same Redis version.
private string _image = "redis:8.0.3";
private string _image = "redis:8.10.1";
private string? _customConfigPath;
private int? _hostPort;
private string? _password;

/// <summary>
/// Sets the Redis Docker image to use. Defaults to "redis:8.0.3".
/// Sets the Redis Docker image to use. Defaults to "redis:8.10.1".
/// </summary>
/// <param name="image">The Redis Docker image tag</param>
/// <returns>The builder instance for method chaining</returns>
Expand Down