Repository navigation
Conversation
Contributor
Author
|
Update: this branch has been refreshed with the latest |
prx-my
force-pushed
the
refactor/issue-1244-sarif-options-object
branch
from
October 8, 2026 11:46
8a8e18f to
fd84108
Compare
prx-my
force-pushed
the
refactor/issue-1244-sarif-options-object
branch
from
October 8, 2026 11:50
fd84108 to
01001a2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1244.
Converts the trailing optional parameters of the two SARIF entry points to a
single options object, keeping
findings,lockfileUri,versionandplanpositional:
buildSarifOutput(findings, lockfileUri, version, plan, options?)writeSarifReport(findings, lockfileUri, plan, options?)optionscarriesoverrideFindings,maintenanceFindings,licenseFindingsand
overrideSkipped; the writer addsoutputDir. Behaviour is unchanged.Replaces the two brittle
write-outputstests that asserted call arity and thefull positional list with assertions on the options object. Call sites that pass
only the leading arguments are untouched.
Verified:
npm run lint:tests,npm run build, advisories sync,npm test(163 suites / 2249 tests).