Skip to content

fix: bounds clamp index typo #172 - #190

Merged
oliverchampion merged 1 commit into
OSIPI:mainfrom
atharva-vaish240:fix/ogc-bayesian-bounds
Nov 9, 2026
Merged

oliverchampion merged 1 commit into
OSIPI:mainfrom
atharva-vaish240:fix/ogc-bayesian-bounds

Conversation

@atharva-vaish240

Copy link
Copy Markdown
Contributor

Describe the changes you have made in this PR

This PR fixes a bounds clamping index typo in OGC_AmsterdamUMC_Bayesian_biexp.ivim_fit().

Previously, when a parameter fell outside the defined bounds, the clamp incorrectly overwrote the diffusion coefficient at fit_results[0] instead of updating the offending parameter at fit_results[i]. This update corrects the index mapping.

Contributor Information:

  • Atharva Vaish

Fixes #172

Checklist

  • Self-review of changed code
  • Added automated tests where applicable

@atharva-vaish240

Copy link
Copy Markdown
Contributor Author

@IvanARashid pls have a look at it

@oliverchampion
oliverchampion merged commit cc64d36 into OSIPI:main Nov 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Bounds clamp in OGC_AmsterdamUMC_Bayesian_biexp.ivim_fit() writes to index 0 instead of i

2 participants