Repository navigation
#15035: Guard crash handler against re-entry and use _Exit - #15042
Merged
Merged
Conversation
magnesj
added
the
System
magnesj
force-pushed
the
15035-crash-handler-reentry
branch
from
October 26, 2026 12:47
fe8a6e0 to
740c329
Compare
kriben
reviewed
Oct 26, 2026
kriben
left a comment
kriben
left a comment
Collaborator
There was a problem hiding this comment.
Crash-handler review finding
kriben
reviewed
Oct 26, 2026
kriben
left a comment
kriben
left a comment
Collaborator
There was a problem hiding this comment.
Automated review (OCR delegation mode). Coverage: 3/3 files reviewed.
The approach looks good overall. Two medium issues can cause the crash report this PR wants to keep to be lost: the cross-thread re-entry _Exit and the 15 s watchdog vs. the telemetry flush timeout. See the inline comments.
…Qt messages in crash reports
magnesj
force-pushed
the
15035-crash-handler-reentry
branch
from
October 26, 2026 13:08
740c329 to
db6657c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15035
Not included: avoiding paint/update event dispatch while waiting for the telemetry reply.