Repository navigation
#14980: Remove global max segment length from segment collection - #14981
Merged
Merged
Conversation
kriben
approved these changes
Oct 19, 2026
Max segment length is specified on the individual segment intervals.
The global max segment length no longer exists, so segment subdivision is defined only by the segment intervals.
magnesj
force-pushed
the
remove-global-max-segment-length
branch
from
October 19, 2026 18:10
c95ce57 to
d81992b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segment length limits are specified per segment interval, so the global "Enforce Max Segment Length" / "Max Segment Length" fields on the segment collection are redundant.
m_enforceMaxSegmentLength,m_maxSegmentLengthandmaxSegmentLength()fromRimSegmentCollection, including UI, top-level inheritance and legacy import (no migration).Fixes #14980