Repository navigation
[19.0][FIX] project_task_name_with_id: name_search() with a domain keyword - #1885
Open
parabol123654 wants to merge 1 commit into
Open
parabol123654 wants to merge 1 commit into
parabol123654 wants to merge 1 commit into
Conversation
Since 19.0 the second parameter of name_search() is called domain, and the web client passes it by keyword (Search More with a text, search bar, record selectors). The override still called it args, so those calls on tasks failed with "got an unexpected keyword argument 'domain'".
AungKoKoLin1997
approved these changes
Nov 11, 2026
AungKoKoLin1997
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix.
Non-blocking: for the test, could you please consider calling name_search("Test task", domain=[...]) at the end of the existing test_name_search instead? That keeps the name_search tests in one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 19.0, the second parameter of
name_search()is calleddomain(it wasargs). The web client passes it by keyword: "Search More..." after typing in a many2one, the search bar autocompletion, record selectors and the calendar filter panel all callname_searchwith{name, domain, operator, limit}. The override in this module still declaresargs, so all these calls on tasks fail:The plain many2one dropdown keeps working, because
web_name_searchpasses the arguments by position.The fix renames the parameter to
domain, as core does.Test:
test_name_search_domain_keywordcallsname_searchthroughcall_kwwith the domain by keyword, as the web client does.TypeErrorabove.