Skip to content

[IMP] mechanical review gate as first filter - #367

Open
max3903 wants to merge 3 commits into
masterfrom
imp-review-gate-first-filter
Open

max3903 wants to merge 3 commits into
masterfrom
imp-review-gate-first-filter

Conversation

@max3903

@max3903 max3903 commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Summary

The bot should be a volume filter in front of reviewers, not a reviewer and not a merger.

This follows the contributors@ thread Proposal: allow merging green, untouched PRs after 10 days. This PR does not let the author /ocabot merge after 10 days of silence, and it does not escalate silent PRs with extra pings.

Holger Brunn (contributors@, 2026-09-30): silence can mean the PR is uninteresting; do not add a 7/14/21 ping ladder. That job was dropped from this PR.

Pipeline

  1. Contributor opens the PR.
  2. Mechanical checks comment on the PR (<!-- ocabot-review-gate -->) and set/remove bot checks passed.
  3. Human reviewer / maintainer (existing mention + needs review).
  4. After 2 approvals and 5 days: ready to merge (comment now includes the PSC list).

Silence is left as a human signal. The bot never merges and never counts as a review.

Mechanical checks

  • Must fix: missing development_status; new addon that defines _name models without security/ir.model.access.csv.
  • Please check: non-Alpha / Production-Stable / Mature addons; new addon name collision on the series; models dir without ACL file.

The comment states explicitly that this is not a review and the bot will not merge.

Opt-in first filter

REVIEW_GATE_AS_FIRST_FILTER=true delays maintainer pings and the needs review label until mechanical checks and CI are green. Default is false so current OCA behaviour stays until we decide to enable it.

Disable with BOT_TASKS_DISABLED=review_gate if needed.

Not in this PR (follow-ups)

  • Cross-repo duplicate module name search on the whole OCA org.
  • Commit-history rewrite detection for migrations.
  • Exact PSC team slug instead of @OCA/<repo>-maintainers guess.

Tests

pytest tests/test_review_gate.py tests/test_on_pr_review_gate.py

max3903 and others added 2 commits September 30, 2026 16:56
Add a volume filter in front of human reviewers: missing
development_status, obvious ACL holes on new addons, and warnings for
non-Alpha / possible name collisions. The bot comments a checklist and
never merges or counts as a review.

Escalate PRs that stay on needs review with no human reply (7 / 14 / 21
days) to a wider team. Optional REVIEW_GATE_AS_FIRST_FILTER delays
maintainer pings until checks and CI are green.
Holger Brunn (contributors@, 2026-09-30): silence can mean the PR is
uninteresting; do not add a 7/14/21 ping ladder. Keep the mechanical
review gate and the ready-to-merge PSC link. Restore Tecnativa credits
dropped in the previous README edit.
@max3903 max3903 changed the title [IMP] mechanical review gate and silent-PR escalation [IMP] mechanical review gate as first filter Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants