Repository navigation
feat: add Sonarr /api/v5 endpoints to templates - #126
Merged
austinwbest merged 1 commit intoOct 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Adds
/api/v5/...endpoints next to the existing/api/v3/...ones in every Sonarr template, so consumers pointed at a Sonarr v5 through the proxy keep working when they move to the v5 API. v3 entries are unchanged.Changes
root/app/www/public/templates/sonarr/: for each granted/api/v3/<path>, the same<path>and methods are granted under/api/v5/.isAllowedEndpointmatches the request path against the template keys, so it needs no v5 awareness.Testing
Built the image from this branch (
starrproxy-v5test:local), ran it on127.0.0.1:18080with a fresh/configper template, backed by a throwaway Sonarr5.0.0.2742(ghcr.io/hotio/sonarr:nightly-5.0.0.2742) with a throwaway API key. Each template was registered through/api/addstarr, then every endpoint in the template was called with GET, POST, PUT, and DELETE using the scoped key./api/v3and/api/v5endpointautobrr:/api/v3/system/status,/api/v5/system/status,/api/v5/seriesversion5.0.0.2742)autobrr:/api/v5/rootfolder(not granted)starr_id)Result: 1851 checks, 1848 pass. The 3 mismatches are all the same case:
cross-seed.jsonhas a bare/apikey (already ondevelop), and the script's POST/PUT/DELETE to/apigot an nginx 404 instead of 405. No v5 key is involved.Not run: websocket and revoked-key check, since no PHP changed. No new files, so no header check.
Notes
🤖 Generated with Claude Code