Repository navigation
Conversation
… shared/src/change-request-utils.ts
Steph375
requested changes
Oct 11, 2026
Steph375
requested changes
Oct 15, 2026
Steph375
left a comment
Steph375
left a comment
Contributor
There was a problem hiding this comment.
Wow so quick! just a couple more little things!
Contributor
Author
Basically I get this error above. It is a linter error so it is not syntactically wrong, and I do not think its worth disabling this linter error for this one line
|
Steph375
changed the base branch from
develop
to
feature/change-request-buffer
October 16, 2026 14:05
glickgNU
changed the base branch from
feature/change-request-buffer
to
change-requests-speed-refactor
October 16, 2026 21:04
glickgNU
changed the base branch from
change-requests-speed-refactor
to
feature/change-request-buffer
October 16, 2026 21:05
wavehassman
requested changes
Oct 17, 2026
| ' The start date for ' + | ||
| name + | ||
| ' has been changed from ' + | ||
| startDateString + |
Contributor
There was a problem hiding this comment.
pretty sure the two start dates need to be swapped
| wbsString: string, | ||
| name: string | ||
| ) => { | ||
| const leadIdPing = (await pingBasedOnId(leadId)) || ''; |
Contributor
There was a problem hiding this comment.
I would rather use getUserSlackMentionOrName
| * @param name Name of the work package | ||
| */ | ||
| export const sendActivationStartDateChangedNotification = async ( | ||
| teams: (Team & { teamType: Team_Type | null })[] | undefined, |
Contributor
There was a problem hiding this comment.
why is this not just an array of teams?
| * @param managerId The work package's manager | ||
| * @param startDate The planned starting date for the work package | ||
| * @param activationDate The actual starting date for the work package | ||
| * @param bufferDays The threshold that triggers this message |
| }; | ||
|
|
||
| /** | ||
| * Sends to team channels as well as leads and manager about |
Contributor
There was a problem hiding this comment.
this only sends to the team channels pinging the lead and manager
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When the activation and planned start for a work package differ more than the buffer threshold, the associated lead, manager, and teams will be notified on slack.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4411