Repository navigation
Measure graph performance in verify-graph, and name port holders in run-local - #74
Merged
Merged
Conversation
…, port holders Co-authored-by: Wyatt Bracy <138251570+bracyw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
verify-graph gets an optional performance probe,
perf.sh. It reports JS heap, allocation rate and frames, plus the browser's GPU-process memory, which is where WebGL charts differ. check.js now waits for the Quick Select options before counting them, which fixes a race that failed checks 4 and 5 under load. The skill now gives theplaywright-cliinstall steps and notes Calypso's low data rate. When every port is taken, run-local names what holds each one.Diagram
Testing
Notes
simulate --helpoffers only topic filters), so the skill says to treat small JS-heap gaps as noise rather than adding a stress mode.Checklist
ci/check.sh .andbash tests/e2e.shpass.delphi/manifest.ymlfile changed (none changed)