Repository navigation
test(cpworker): use an 8 MB capture buffer in the timeout_ms > 0 integration tests - #318
Merged
Merged
Conversation
…gration tests CLOUD-PROBE-BUILD #175 and #176 failed in TestIdleZMQFlush and TestIdleCapture with "worker did not start polling": cpworker logged the libpcap version and then did not reach "start poll packets" within the tests' 5 s wait. Each build failed different timeout_10ms subtests, and #174 passed on the same commit. With timeout_ms > 0 and the default 256 MB buffer, cpworker startup is slow when the host is short of free memory. In a VM with memory filled to swap, startup took up to ~1 s with timeout_ms 10 and 256 MB, and stayed under ~170 ms with an 8 MB buffer or timeout_ms 0. The tests send at most a few thousand packets, so the idle capture tests and the reload dest_a/dest_b configs (also timeout_ms 10) now set buffer_size_mb 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CLOUD-PROBE-BUILD #175 and #176 failed in the cpworker integration tests with
worker did not start polling:TestIdleZMQFlush/rtc/timeout_10ms,TestIdleZMQFlush/pipeline/timeout_10msTestIdleCapture/rtc/timeout_10ms/shutdownIn each case cpworker logged
libpcap version: 1.6.2and then did not reachstart poll packetswithin the tests' 5 s wait. #174 passed on the same cloud-probe commit (a02be2a). Onlytimeout_10mssubtests failed, a different one each time.Cause
With
timeout_ms > 0and the default 256 MBbuffer_size_mb, cpworker startup is slow when the host is short of free memory. Startup time tostart poll packets, libpcap 1.6.2, Ubuntu 24.04 VM:The VM did not reach 5 s; the CI build pod's host is presumably under more memory pressure.
Change
Test-only. The tests send at most a few thousand packets, so they set
buffer_size_mb: 8:idle_capture_test.go:writeIdleCaptureConfig(TestIdleCapture, TestIdleZMQFlush).testdata/reload/{rtc,pipeline}_dest_{a,b}.json: alsotimeout_ms: 10with the default buffer (TestReload/switch_output_destination).Tests
run_test.sh allok.