Repository navigation
Pass isEnumerator value to OnCreateProxyShareEventArgs - #525
Open
NopeCharon wants to merge 1 commit into
Open
NopeCharon wants to merge 1 commit into
NopeCharon wants to merge 1 commit into
Conversation
The `OnCreateProxyShareEventArgs` constructor assigned the `IsEnumerator` property to itself instead of storing the `isEnumerator` argument. As a result, every `Core.CreateProxyShare` event handler observed `false`, even when `Core.CreateNewProxyShare()` was called for an enumerator proxy, and a custom handler could not create a `COMProxyShare` with the enumerator release behavior. Store the constructor argument and add a unit test which raises the `CreateProxyShare` event through `Core.CreateNewProxyShare()` and checks the value observed by the event handler. Fixes NetOfficeFw#482
jozefizso
approved these changes
Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Core.OnCreateProxyShareEventArgsassigned itsIsEnumeratorproperty to itself instead of theisEnumeratorconstructor argument. EveryCore.CreateProxyShareevent handler sawfalse, even whenCore.CreateNewProxyShare()was called for an enumerator proxy. A custom handler therefore could not create aCOMProxySharewith the enumerator release behavior.Changes
isEnumeratorconstructor argument inOnCreateProxyShareEventArgs.CoreTests, which raises theCreateProxyShareevent throughCore.CreateNewProxyShare()for both values and checks what the handler sees. The test usesFakeComObjectand doesn't need Office.Fixedchangelog entry underv2.0.0-preview.Verification
isEnumerator: truecase fails (Expected: True But was: False). With the fix, both cases pass.Fixes #482